Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brand Updates] Update promo screenshots colors #14765

Merged
merged 1 commit into from
Dec 26, 2024
Merged

[Brand Updates] Update promo screenshots colors #14765

merged 1 commit into from
Dec 26, 2024

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Dec 25, 2024 •
edited
Loading

Closes: woocommerce/woomobile-private#399

Description

This PR updates the promo screenshots configuration to use the new backgrounds matching the new brand update (Ntkk0ER4hHt5y9KjEGIiGk-fi-2073_1004)

Testing information

I don't think testing is required here, just code review and check the screenshots below.

Screenshots

(Uses old app screenshots)

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@hichamboushaba hichamboushaba added type: enhancement A request for an enhancement. category: screenshots Related to generating screenshots for the App Store. labels Dec 25, 2024
@hichamboushaba hichamboushaba marked this pull request as ready for review December 25, 2024 10:54
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14765-ea08c03
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commitea08c03
App Center BuildWooCommerce - Prototype Builds #12292
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@itsmeichigo itsmeichigo self-assigned this Dec 26, 2024
itsmeichigo
itsmeichigo approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@hichamboushaba hichamboushaba merged commit b2bf9ed into feature/woo-2.0-brand-updates Dec 26, 2024
23 checks passed
@hichamboushaba hichamboushaba deleted the task/woo-2.0-screenshot-updates branch December 26, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@itsmeichigo itsmeichigo

Labels
category: screenshots Related to generating screenshots for the App Store. type: enhancement A request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hichamboushaba @wpmobilebot @itsmeichigo